Skip to content

chore: Update read environment variables guide update with new .env guidance - #6182

Merged
bmuenzenmeyer merged 4 commits into
nodejs:mainfrom
nikhilbhatt:update-read-env-guide-with-latest-changes
Dec 12, 2023
Merged

chore: Update read environment variables guide update with new .env guidance#6182
bmuenzenmeyer merged 4 commits into
nodejs:mainfrom
nikhilbhatt:update-read-env-guide-with-latest-changes

Conversation

@nikhilbhatt

@nikhilbhatt nikhilbhatt commented Dec 11, 2023 •
edited by AugustinMauroy
Loading

Copy link
Copy Markdown
Contributor

Description

Fixes #6140

Validation

Related Issues

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run npx turbo lint to ensure the code follows the style guide. And run npx turbo lint:fix to fix the style errors if necessary.
  • I have run npx turbo format to ensure the code follows the style guide.
  • I have run npx turbo test to check if all tests are passing.
  • NA I've covered new added functionality with unit tests if necessary.

@nikhilbhatt
nikhilbhatt requested a review from a team as a code owner December 11, 2023 17:51
@vercel

vercel Bot commented Dec 11, 2023 •
edited
Loading

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 12, 2023 10:35pm

@nikhilbhatt
nikhilbhatt force-pushed the update-read-env-guide-with-latest-changes branch from 74b0687 to f7fe743 Compare December 11, 2023 18:02
@nikhilbhatt nikhilbhatt changed the title [UPDATE] Read environment variables guide update with new .env guidance chore: Update read environment variables guide update with new .env guidance Dec 11, 2023
@ovflowd ovflowd added the github_actions:pull-request Trigger Pull Request Checks label Dec 11, 2023
@github-actions github-actions Bot removed the github_actions:pull-request Trigger Pull Request Checks label Dec 11, 2023
@github-actions

github-actions Bot commented Dec 11, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

Lighthouse Results

URL Performance Accessibility Best Practices SEO Report
/en 🟢 100 🟢 97 🟢 92 🟢 92 🔗
/en/about 🟢 100 🟢 95 🟢 92 🟢 92 🔗
/en/about/previous-releases 🟢 100 🟢 93 🟢 92 🟢 92 🔗
/en/download 🟢 100 🟢 95 🟢 92 🟢 92 🔗
/en/blog 🟢 100 🟢 95 🟢 92 🟢 92 🔗

@github-actions

github-actions Bot commented Dec 11, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

Unit Test Coverage Report

Lines Statements Branches Functions
Coverage: 91%
 86.91% (392/451) 73.04% (103/141) 80.45% (70/87)

Unit Test Report

Tests Skipped Failures Errors Time
71 0 💤 0 ❌ 0 🔥 4.167s ⏱️

@AugustinMauroy

AugustinMauroy commented Dec 11, 2023

Copy link
Copy Markdown
Member

Personally, I would have removed the part that talks about the dotenv package.

AugustinMauroy
AugustinMauroy approved these changes Dec 12, 2023
View reviewed changes

@AugustinMauroy AugustinMauroy left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !!!
🎉 thanks for your first contribution !!

@AugustinMauroy AugustinMauroy added the github_actions:pull-request Trigger Pull Request Checks label Dec 12, 2023
@github-actions github-actions Bot removed the github_actions:pull-request Trigger Pull Request Checks label Dec 12, 2023
bmuenzenmeyer
bmuenzenmeyer approved these changes Dec 12, 2023
View reviewed changes
Comment thread pages/en/learn/command-line/how-to-read-environment-variables-from-nodejs.md Outdated
Comment thread pages/en/learn/command-line/how-to-read-environment-variables-from-nodejs.md Outdated
@bmuenzenmeyer
Apply suggestions from code review
4cbfa4d 
Signed-off-by: Brian Muenzenmeyer <brian.muenzenmeyer@gmail.com>
@bmuenzenmeyer bmuenzenmeyer added the github_actions:pull-request Trigger Pull Request Checks label Dec 12, 2023
@github-actions github-actions Bot removed the github_actions:pull-request Trigger Pull Request Checks label Dec 12, 2023
@bmuenzenmeyer
bmuenzenmeyer added this pull request to the merge queue Dec 12, 2023
Merged via the queue into nodejs:main with commit e802dfb Dec 12, 2023
@nitin-is-me nitin-is-me mentioned this pull request Feb 17, 2026
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bmuenzenmeyer bmuenzenmeyer bmuenzenmeyer approved these changes
@aymen94 aymen94 aymen94 approved these changes
@AugustinMauroy AugustinMauroy AugustinMauroy approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Update how-to-read-environment-variables-from-nodejs.md with new .env guidance

5 participants

@nikhilbhatt @AugustinMauroy @bmuenzenmeyer @aymen94 @ovflowd